Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction

Kai Uwe Broulik kde at privat.broulik.de
Sun Jul 3 11:26:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128014/
-----------------------------------------------------------

(Updated July 3, 2016, 11:26 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Edmundson.


Changes
-------

Submitted with commit 09cd4a99cb41ca160d1a77fa83dffab07b302a2c by Kai Uwe Broulik to branch master.


Repository: kxmlgui


Description
-------

This makes sure the user is never presented the option to hide the toolbar. Toolbars could still be hidden by unlocking toolbars after which a toolbar action may show up.


Diffs
-----

  src/ktoggletoolbaraction.cpp ceb6d43 

Diff: https://git.reviewboard.kde.org/r/128014/diff/


Testing
-------

Option no longer shows up. (Should've probably also hidden the Qt action in my previous patch since that's what KAuthorized usually does)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160703/1a47d31d/attachment.html>


More information about the Kde-frameworks-devel mailing list