Review Request 128103: Add license texts for KAboutLicense ; add LGPL v2.1 as separate license.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128103/#review97056
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On July 2, 2016, 9:44 p.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128103/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 9:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 353939
>     https://bugs.kde.org/show_bug.cgi?id=353939
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This change fixes a regression from KDE 4 by importing the license texts from KDE4's kdelibs for the non-GPL licenses and for FSF's *GPL licenses downloading the plain text directly from the source. I don't see the licenses in any other KF5 module, and KCoreAddons is what hosts KAboutLicense/KAboutData so it makes sense to land here.
> 
> This permits the "License: $foo" hyperlink in the KAboutDialog to work properly as well (previously there'd be a blank spot where the license would be, now it shows up".
> 
> Since I was working here I added LGPL v2.1 as a separate license, since it has slightly different requirements to the old LGPL v2.0 (and obviously, to LGPL v3). I can make that part a separate RR (or just leave it out, I don't know of any apps using LGPL v2.1 off hand).
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt ef71386 
>   src/lib/kaboutdata.h 9fe4ade 
>   src/lib/kaboutdata.cpp 2be3b62 
>   src/lib/licenses/ARTISTIC PRE-CREATION 
>   src/lib/licenses/BSD PRE-CREATION 
>   src/lib/licenses/CMakeLists.txt PRE-CREATION 
>   src/lib/licenses/GPL_V2 PRE-CREATION 
>   src/lib/licenses/GPL_V3 PRE-CREATION 
>   src/lib/licenses/LGPL_V2 PRE-CREATION 
>   src/lib/licenses/LGPL_V21 PRE-CREATION 
>   src/lib/licenses/LGPL_V3 PRE-CREATION 
>   src/lib/licenses/QPL_V1.0 PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128103/diff/
> 
> 
> Testing
> -------
> 
> Compiles, and installs. Once installed, apps have their licenses show up when those licenses are in the set of well-known licenses we provide.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160703/26e1efd3/attachment.html>