Review Request 128237: add failing unit test likely showing off bug 232843

David Faure faure at kde.org
Sat Jul 2 11:01:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128237/#review97021
-----------------------------------------------------------


Fix it, then Ship it!




Since I can't apply locally to debug it (binary file missing), you might as well push it (unless you find the time to fix it fully first).


autotests/kfiltertest.cpp (line 443)
<https://git.reviewboard.kde.org/r/128237/#comment65551>

    Please add reference to the bug number here or in a comment somewhere.


- David Faure


On June 18, 2016, 2:21 p.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128237/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 2:21 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Create unit test with expected failure to likely handle bug 232843
> 
> 
> Diffs
> -----
> 
>   autotests/kfiltertest.h e03c0e1 
>   autotests/kfiltertest.cpp a54eb4a 
> 
> Diff: https://git.reviewboard.kde.org/r/128237/diff/
> 
> 
> Testing
> -------
> 
> test data missing because binary data. but can easily be recreated
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/2db5b403/attachment.html>


More information about the Kde-frameworks-devel mailing list