Review Request 128260: Verify that QWindow::fromWinId returned a QWindow before using it

David Faure faure at kde.org
Sat Jul 2 10:56:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128260/#review97020
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On June 20, 2016, 2:12 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128260/
> -----------------------------------------------------------
> 
> (Updated June 20, 2016, 2:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Foreign window support is not available on all platforms. E.g. on
> Wayland this returns a nullptr. Thus we cannot use it.
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem.cpp 407a67dbf1cade5adf648de25eddf9ec45db30fa 
> 
> Diff: https://git.reviewboard.kde.org/r/128260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/61d5d940/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list