Review Request 128023: Deprecate authorizeKAction() in favor of authorizeAction()

[David Faure]

> On May 26, 2016, 11:58 a.m., Kai Uwe Broulik wrote:
> > -1
> > 
> > While it was errorneously ported to this action all over the place when it should not have been, KXmlGui actions and other menu and toolbar actions should still use the action/ prefix.
> 
> Elvis Angelaccio wrote:
>     I'm not sure I follow, I'm not changing the implementation. Are you saying that client code should always use `KAuthorized::authorize("action/" + actionName)` ? And we should deprecate `authorizeKAction()` without a replacement?

Kai Uwe: I don't understand your comment either. This fix is only about the method name looking weird.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128023/#review95822
-----------------------------------------------------------


On May 26, 2016, 11:35 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128023/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 11:35 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> We don't use anymore KActions, so both the function name and its documentation should be updated in favor of QAction (though I chose to use authorizeAction() because authorizeQAction() looks bad to me).
> 
> 
> Diffs
> -----
> 
>   src/core/kauthorized.h d098823469b1c2e0ed7a23e0a245a6c6b8c59868 
>   src/core/kauthorized.cpp 993a5e863e9c541ab963e114ae3e3819a1bbf0ff 
> 
> Diff: https://git.reviewboard.kde.org/r/128023/diff/
> 
> 
> Testing
> -------
> 
> Builds. All tests pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/044ef4a7/attachment-0001.html>