Review Request 127469: Use QQuickWidget for QML KCMs

[David Rosca]

> On July 2, 2016, 8:26 a.m., David Faure wrote:
> > src/kcmoduleqml.cpp, line 112
> > <https://git.reviewboard.kde.org/r/127469/diff/2/?file=453795#file453795line112>
> >
> >     This line breaks compilation with Qt 5.4 (quickWindow() doesn't exist).
> >     
> >     http://ci-logs.kde.flaska.net/d4/d42402a0b5581707d019bb9db0b074b1775083a1/rebuilddep/rebuilddep-kf5-qt54-gcc-el7/b301f2c/shell_output.log

https://git.reviewboard.kde.org/r/128340/


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127469/#review97002
-----------------------------------------------------------


On May 20, 2016, 1:33 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127469/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 359124
>     https://bugs.kde.org/show_bug.cgi?id=359124
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Fix position of QtQuickControls popups.
> 
> BUG: 359124
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 60cf4bb 
>   src/CMakeLists.txt 58352f6 
>   src/kcmoduleqml.cpp c52769b 
> 
> Diff: https://git.reviewboard.kde.org/r/127469/diff/
> 
> 
> Testing
> -------
> 
> Popups are now in correct position in systemsettings and kcmshell
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/13b13709/attachment.html>