API review: FavIconManager vs FavIconHostRequestJob

Kevin Ottens ervin at kde.org
Sun Jan 31 19:31:54 UTC 2016


Hello,

On Sunday, 31 January 2016 10:40:12 CET David Faure wrote:
> On Thursday 28 January 2016 09:35:53 laurent Montel wrote:
> > Yep some time I forgot it in kmail when I used manual call to start.
> > So if you want to use it make it automatic it's better.
> 
> I agree, but then I wonder why KJob doesn't autostart (with an early
> exit in start if it was already called). Kévin?

The inconsistency is bad indeed. It's mainly there because we couldn't change 
KIO back in the time of the Qt3->Qt4 transition due to the massive porting 
effort it would have been IIRC (although now I think it wouldn't have been 
that hard to script even back then...).

The problem with auto-started jobs is that it prevents creating jobs and 
storing them for later starting them only when needed (that's an annoyance I 
had a couple of times with Akonadi which decided to replicate KIO in that 
regard).
 
Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160131/f4c717a2/attachment.sig>


More information about the Kde-frameworks-devel mailing list