Review Request 126940: Move .protocol files of all io slaves bundled in kio to JSON meta data

[Christoph Cullmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126940/
-----------------------------------------------------------

(Updated Jan. 31, 2016, 3:41 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Repository: kio


Description
-------

Move .protocol files of all io slaves bundled in kio to JSON meta data.
Second try, this time with i18n aware protocoltojson used.


Diffs
-----

  autotests/kprotocolinfotest.cpp 812f7f7 
  src/ioslaves/file/CMakeLists.txt cb85cfb 
  src/ioslaves/file/file.cpp 381e488 
  src/ioslaves/file/file.json PRE-CREATION 
  src/ioslaves/file/file.protocol 523c0f5 
  src/ioslaves/ftp/CMakeLists.txt 04f5600 
  src/ioslaves/ftp/ftp.cpp 7477a6a 
  src/ioslaves/ftp/ftp.json PRE-CREATION 
  src/ioslaves/ftp/ftp.protocol 4c5f80c 
  src/ioslaves/help/CMakeLists.txt 867b59d 
  src/ioslaves/help/ghelp.json PRE-CREATION 
  src/ioslaves/help/ghelp.protocol d2a642a 
  src/ioslaves/help/help.json PRE-CREATION 
  src/ioslaves/help/help.protocol 1deefe5 
  src/ioslaves/help/main.cpp 9939196 
  src/ioslaves/help/main_ghelp.cpp 59c8558 
  src/ioslaves/http/CMakeLists.txt da5601e 
  src/ioslaves/http/http.cpp a84129f 
  src/ioslaves/http/http.protocol 49e5dc5 
  src/ioslaves/http/https.protocol c15d06f 
  src/ioslaves/http/webdav.protocol 05c977a 
  src/ioslaves/http/webdavs.protocol d5e4b2f 
  src/ioslaves/trash/CMakeLists.txt 05161cd 
  src/ioslaves/trash/kio_trash.cpp 81cc036 
  src/ioslaves/trash/trash.json PRE-CREATION 
  src/ioslaves/trash/trash.protocol 7430575 

Diff: https://git.reviewboard.kde.org/r/126940/diff/


Testing (updated)
-------

Compile and tests seem to work, this time the i18n strings look better in trash.json, compared to my first try in https://git.reviewboard.kde.org/r/125869/


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160131/46fe64ba/attachment.html>