Review Request 126675: Add .kra and .ora qimagio plugins

[Boudewijn Rempt]

> On Jan. 31, 2016, 1:03 p.m., Alex Merry wrote:
> > CMakeLists.txt, line 22
> > <https://git.reviewboard.kde.org/r/126675/diff/2/?file=441771#file441771line22>
> >
> >     What about making this optional (and only building those two plugins if it is found)?

Fine with me.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/#review91821
-----------------------------------------------------------


On Jan. 27, 2016, 9:48 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126675/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 9:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> These qimageio plugins originally come from krita, but people who haven't got krita installed might want to view Krita or OpenRaster images as well. Both formats are really simple, just zip files with a png inside that represents the merged image. This patch does add a KF5::Archive dependency to kimageformats.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1e7e703 
>   autotests/CMakeLists.txt 853607e 
>   autotests/read/kra/src.kra PRE-CREATION 
>   autotests/read/kra/src.png PRE-CREATION 
>   autotests/read/ora/src.ora PRE-CREATION 
>   autotests/read/ora/src.png PRE-CREATION 
>   src/imageformats/CMakeLists.txt 8cf8d54 
>   src/imageformats/kra.cpp PRE-CREATION 
>   src/imageformats/kra.desktop PRE-CREATION 
>   src/imageformats/kra.h PRE-CREATION 
>   src/imageformats/kra.json PRE-CREATION 
>   src/imageformats/ora.cpp PRE-CREATION 
>   src/imageformats/ora.desktop PRE-CREATION 
>   src/imageformats/ora.h PRE-CREATION 
>   src/imageformats/ora.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160131/2216be2c/attachment.html>