Review Request 126903: Fix buddy widgets working with KFontRequester

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126903/#review91797
-----------------------------------------------------------


Ship it!




It has always been this way in Qt, that you can set the focus policy of the widget and its focusproxy differently.
In simple cases like this it doesn't make sense indeed, I don't know about more complex cases. Sounds scary to change in Qt in any case, IMHO.

- David Faure


On Jan. 27, 2016, 1:42 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126903/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 1:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> A focusProxy doesn't automatically inherit the focusPolicy of the child which means
> some focus events weren't getting passed on. In particular a QLabel with a KFontRequester as a buddy widget wouldn't get focus when pressing the accelerator shortcut keys.
> 
> 
> Diffs
> -----
> 
>   src/kfontrequester.cpp 3fb4296bba479dcb87ae75b48a2ee7ab57c000a8 
> 
> Diff: https://git.reviewboard.kde.org/r/126903/diff/
> 
> 
> Testing
> -------
> 
> Fixed fonts KCM.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160130/66fb5073/attachment.html>