Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

[Andre Heinecke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126895/
-----------------------------------------------------------

(Updated Jan. 28, 2016, 1:29 p.m.)


Review request for KDE Frameworks.


Changes
-------

Only make GlobalAccel optional for non UNIX builds.


Repository: kxmlgui


Description
-------

This is part of a three patch series that aims to allow a "leightweight" build of KXmlGui without DBus and KService dependencies. I've added the patches to: https://phabricator.kde.org/T1390 I'm not sure if I can create reviews that depend on changes from another review, I'll try and if it does not work I'll open one after another.

Global shortcuts are a nice optional feature to have. But as they are not strictly neccessary for the core functionality of KXmlGui, as I see it, and pull in an extra dependency to DBus and need runtime support on the target platform they should be optional.

This (and the other changes) add lots of unloved ifdefs, I could understand if thats disliked. But let me explain the background of this change:

I'm currently updating Kleopatra in Gpg4win to a KDE Frameworks based build. This is nice. Frameworks are awesome, I can just pick what I need and don't have dependencies to lots of things that are actually not needed.
Then comes KXmlGui, adds 20 Framework dependencies, and I don't know what to do.
I want:
- configureable "KDE Style" GUI
- configurable Shortcuts
- KDE Standardactions (e.g. Help / WhatsThis)
- kbugreport
- KDE Integration in an KDE Environment

But I don't want:
- Global Shortcuts (we don't have kded so this won't work for us anyway)
- DBus (our dbus is directory scoped and there are no other applications using dbus installed by us)
- KService dependency (System configuration has been troublesome in the past on Windows and is not neccessary if we provide just a single installation)

So these Patches are my way out of this Problem. Without the optional packages KXmlGui provides what I want and does not depend on what I don't want.


Diffs (updated)
-----

  CMakeLists.txt 9d79619 
  src/CMakeLists.txt 58f0c7a 
  src/config-xmlgui.h.cmake 07c882f 
  src/kactioncollection.cpp 9c45725 
  src/kkeysequencewidget.cpp b2e2b6a 
  src/kshortcuteditwidget.cpp 670d031 
  src/kshortcutseditor.cpp 99dfb3d 
  src/kshortcutseditoritem.cpp 461a90c 
  src/kxmlguifactory.cpp 2767e69 

Diff: https://git.reviewboard.kde.org/r/126895/diff/


Testing
-------

Compiled with and without dependency. Tested Kleopatra against it.
Not yet tested on Windows, will do so in the next days.


Thanks,

Andre Heinecke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160128/641062a7/attachment.html>