[karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

[Aleix Pol]

On Sat, Jan 23, 2016 at 12:05 PM, David Faure <faure at kde.org> wrote:
> On Tuesday 19 January 2016 10:11:06 Aleix Pol wrote:
>> On Tue, Jan 19, 2016 at 9:15 AM, David Faure <faure at kde.org> wrote:
>> > Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure.
>> > Committed on 19/01/2016 at 08:14.
>> > Pushed by dfaure into branch 'master'.
>> >
>> > Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).
>> >
>> > Any volunteer for doing this over all frameworks?
>> > CCMAIL: kde-frameworks-devel at kde.org
>> >
>> > M  +1    -1    CMakeLists.txt
>> >
>> > http://commits.kde.org/karchive/3b13ef97925725b2a273a4d3e7d1c0c7e151522d
>> >
>> > diff --git a/CMakeLists.txt b/CMakeLists.txt
>> > index 1440f2f..deee520 100644
>> > --- a/CMakeLists.txt
>> > +++ b/CMakeLists.txt
>> > @@ -11,7 +11,7 @@ feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKA
>> >  set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
>> >
>> >  include(KDEInstallDirs)
>> > -include(KDEFrameworkCompilerSettings)
>> > +include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
>> >  include(KDECMakeSettings)
>>
>> Hi,
>> I'll work on a GCI task over it. Should be easy enough.
>
> Excellent idea, thanks.
>
> Note: this should *not* lead to 70 reviewboard requests ;)
>
> If the person doing this has made sure he has no other local changes, then a script is OK.
>
>> PS: Actually we should get this in applications as well, right?
>
> Yes, although the patch will be slightly different there (KDECompilerSettings, not KDEFrameworkCompilerSettings).
>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>

No student picked it up, so I'll do it myself.

Aleix