Review Request 126864: kio_http_cache_cleaner: don't exit on startup if cache dir doesn't exist yet
David Faure
faure at kde.org
Wed Jan 27 07:41:08 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126864/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 7:41 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit 9331d94ee183b39fd985d27cdaa547c75fb65931 by David Faure to branch master.
Repository: kio
Description
-------
+ add warning if listen fails, just in case
Change-Id: I27c8b166a6127fad3793024bdb950239ffc93d35
Diffs
-----
src/ioslaves/http/http_cache_cleaner.cpp c272c6ecc75ef07418cdfe4a17af4b0475d6ff0a
Diff: https://git.reviewboard.kde.org/r/126864/diff/
Testing
-------
I was getting
kio_http_cache_cleaner: '/home/dfaure/.cache/http' does not exist.
Maybe it was only because the unittest was using ~/.qttest/cache (QStandardPaths test mode), which is passed along to kio_http, which then talks to kio_http_cache_cleaner without telling it where the cache is, so they disagree on the cache. Corner case due to different paths in unit-tests, but can't hurt to mkpath.
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160127/7921893b/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list