Review Request 126858: Change DBus name of kio_http_cache_cleaner so it doesn't exit if the kde4 one is running.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126858/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 7:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 9c6ce5b155ff286c5a735783b95bfc017d35e13b by David Faure to branch master.


Repository: kio


Description
-------

This DBus service name is only used for "unique app" behaviour.
It's not used for actual DBus communication: the communication from kio_http
comes over a local socket. Since that socket is in ~/.kde/socket-$HOSTNAME
in kde4 and XDG_RUNTIME_DIR in KF5, the KF5 app can't talk to the
kdelibs4 cache cleaner, it does need to be able to start the KF5 instance.
The cache itself is in a different dir too anyway.

Change-Id: I474cccf0e1a6b52ddef9fd5f90c4c40b9e4d7504


Diffs
-----

  src/ioslaves/http/http_cache_cleaner.cpp c272c6ecc75ef07418cdfe4a17af4b0475d6ff0a 

Diff: https://git.reviewboard.kde.org/r/126858/diff/


Testing
-------

Before:

HTTPProtocol::sendCacheCleanerCommand: starting "/d/kde/inst/kde_frameworks/lib64/libexec/kf5/kio_http_cache_cleaner"
HTTPProtocol::sendCacheCleanerCommand: connecting to "/run/user/1000/kio_http_cache_cleaner"
[...]
HTTPProtocol::sendCacheCleanerCommand: Could not connect to cache cleaner, not updating stats of this cache file.
kio_http_cache_cleaner: Already running!

After:
Hmm, now it does run, but still "Could not connect". Must be another bug. Expect more patches...


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160127/ff96330c/attachment.html>