Review Request 126876: Fix QFileDialog::openUrl() for remote files

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126876/#review91605
-----------------------------------------------------------




src/platformtheme/kdeplatformfiledialoghelper.cpp (line 195)
<https://git.reviewboard.kde.org/r/126876/#comment62593>

    OK then you can remove the "is that a BUG" question here.
    
    I'm still curious as to who is passing a url with a filename here; Qt or the app.
    
    In any case the comment is confusing, "Qt returns", this is rather about Qt calling this method, not "returning".



src/platformtheme/kdeplatformfiledialoghelper.cpp (line 201)
<https://git.reviewboard.kde.org/r/126876/#comment62594>

    No need for KFileItem just for that, use entry.isDir().


- David Faure


On Jan. 24, 2016, 9:19 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126876/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 9:19 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> This fix is a bit like Alex Richardson workaround in KIO (https://git.reviewboard.kde.org/r/126831/), but in frameworkintegration in stead (I did not see his/Your KIO fix before now...)
> 
> I check the remote url in setDirectory() because setDirectoy() is called from two places.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 
> 
> Diff: https://git.reviewboard.kde.org/r/126876/diff/
> 
> 
> Testing
> -------
> 
> Kate now happily opens local and remote folders :)
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160126/fa143489/attachment.html>