Review Request 126880: Fix QFileDialog::openUrl() for remote files
David Faure
faure at kde.org
Mon Jan 25 08:20:43 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126880/#review91563
-----------------------------------------------------------
Hmm, see https://git.reviewboard.kde.org/r/126876
- David Faure
On Jan. 24, 2016, 11:24 p.m., Alex Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126880/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 11:24 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 345253
> https://bugs.kde.org/show_bug.cgi?id=345253
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> QFileDialog doesn't make an attempt to determine whether remote URLs are
> files or directories so it just passes the file URL to the platform
> file dialog which caused an error popup and a nonexistent directory to
> be selected.
>
> BUG: 345253
>
> Supersedes https://git.reviewboard.kde.org/r/126831/
>
>
> Diffs
> -----
>
> src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efbb66948da40bf19f430f8020f95d0233f8
>
> Diff: https://git.reviewboard.kde.org/r/126880/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160125/e6b063a8/attachment.html>
More information about the Kde-frameworks-devel
mailing list