Review Request 126804: DragArea: Implement grabbing delegate item

David Rosca nowrep at gmail.com
Thu Jan 21 14:26:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126804/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 2:26 p.m.)


Review request for KDE Frameworks.


Changes
-------

Prefer delegateImage + dpi aware image size


Repository: kdeclarative


Description
-------

Implement grabbing image of delegate with QQuickItem::grabToImage.


Diffs (updated)
-----

  src/qmlcontrols/draganddrop/DeclarativeDragArea.h 32092ab 
  src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp ee78ff9 

Diff: https://git.reviewboard.kde.org/r/126804/diff/


Testing
-------

QQuickItem::grabToImage is async, not sure how safe is to delay the start of drag. It seems to work without any issues though.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160121/4a507787/attachment.html>


More information about the Kde-frameworks-devel mailing list