Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

David Edmundson david at davidedmundson.co.uk
Wed Jan 20 09:09:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 9:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 3936e2230d71948d4bd70c062f34d6cbc93e69c3 by David Edmundson to branch master.


Repository: kwindowsystem


Description
-------

appRootWindow is (relatively) expensive and won't change.
nativeEventFilter is called a lot

This should speed things up.

CCBUG: 356479


Diffs
-----

  src/platforms/xcb/kwindowsystem.cpp 9d287043c24894ca3c29c439c7939b139da055e8 
  src/platforms/xcb/kwindowsystem_p_x11.h 3fa82a436d7fe12b50f7e8efd7338faf817f6579 

Diff: https://git.reviewboard.kde.org/r/126818/diff/


Testing
-------

Ran some apps and they seemed to still work.
Not tested any specific functionality.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160120/4f7017a4/attachment.html>


More information about the Kde-frameworks-devel mailing list