Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

[Martin Gräßlin]

> On Jan. 20, 2016, 2:58 a.m., Aleix Pol Gonzalez wrote:
> > src/platforms/xcb/kwindowsystem_p_x11.h, line 147
> > <https://git.reviewboard.kde.org/r/126818/diff/1/?file=434845#file434845line147>
> >
> >     Should this (maybe) be static? Or rather Q_GLOBAL_STATIC?
> >     
> >     Or we'll just have one of those backends anyway?

No need to have it static.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/#review91358
-----------------------------------------------------------


On Jan. 20, 2016, 12:21 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126818/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 12:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> appRootWindow is (relatively) expensive and won't change.
> nativeEventFilter is called a lot
> 
> This should speed things up.
> 
> CCBUG: 356479
> 
> 
> Diffs
> -----
> 
>   src/platforms/xcb/kwindowsystem.cpp 9d287043c24894ca3c29c439c7939b139da055e8 
>   src/platforms/xcb/kwindowsystem_p_x11.h 3fa82a436d7fe12b50f7e8efd7338faf817f6579 
> 
> Diff: https://git.reviewboard.kde.org/r/126818/diff/
> 
> 
> Testing
> -------
> 
> Ran some apps and they seemed to still work.
> Not tested any specific functionality.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160120/a2158d21/attachment.html>