Review Request 126813: Fix build with older polkit

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126813/#review91338
-----------------------------------------------------------



The symbol `polkit_system_bus_name_get_user_sync` doesn't exist in the Debian stable polkit libraries (it doesn't exist in the polkit-1 package sources or Debian patches either). The Debian stable package version is 0.105-8.

The patch does allow polkit-qt-1 to build, but presumably it might lead to link errors if `SystemBusNameSubject::user()` is referenced. Wouldn't it be better to deal with the symbol `polkit_system_bus_name_get_user_sync` in the same manner as `polkit_authority_get_sync` and `polkit_agent_listener_register`, which if they are missing from the libraries, CMakeLists.txt sets the conditional define `POLKIT_QT_1_COMPATIBILITY_MODE`. That could also be used to conditionally compile the code referencing `polkit_system_bus_name_get_user_sync`.

- David Jarvie


On Jan. 19, 2016, 1:09 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126813/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 1:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: polkit-qt-1
> 
> 
> Description
> -------
> 
> Seems like the function exists, but the header declaration is missing
> 
> 
> Diffs
> -----
> 
>   core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/126813/diff/
> 
> 
> Testing
> -------
> 
> compiles now
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160119/f6de437a/attachment.html>