[karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

[Elvis Angelaccio]

2016-01-19 10:11 GMT+01:00 Aleix Pol <aleixpol at kde.org>:

> On Tue, Jan 19, 2016 at 9:15 AM, David Faure <faure at kde.org> wrote:
> > Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure.
> > Committed on 19/01/2016 at 08:14.
> > Pushed by dfaure into branch 'master'.
> >
> > Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).
> >
> > Any volunteer for doing this over all frameworks?
> > CCMAIL: kde-frameworks-devel at kde.org
> >
> > M  +1    -1    CMakeLists.txt
> >
> > http://commits.kde.org/karchive/3b13ef97925725b2a273a4d3e7d1c0c7e151522d
> >
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index 1440f2f..deee520 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -11,7 +11,7 @@ feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND
> FATAL_ON_MISSING_REQUIRED_PACKA
> >  set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
> >
> >  include(KDEInstallDirs)
> > -include(KDEFrameworkCompilerSettings)
> > +include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
> >  include(KDECMakeSettings)
>
> Hi,
> I'll work on a GCI task over it. Should be easy enough.
>
> Good call!
>
> Aleix
>
> PS: Actually we should get this in applications as well, right?
>

I think so, according to the new documentation [1].
That's what I did for Ark just yesterday [2].

[1]:
https://quickgit.kde.org/?p=extra-cmake-modules.git&a=commitdiff&h=70f8c5f9efaae8f16874d8cfc551e8ae19558fba
[2]:
https://quickgit.kde.org/?p=ark.git&a=commitdiff&h=0620063eb33acff078a0cdededb42e822bb802d3


> _______________________________________________
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160119/e1aaf9d6/attachment.html>