Review Request 126769: Fix all Clazy warnings in KDED.

David Faure faure at kde.org
Tue Jan 19 08:08:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126769/#review91307
-----------------------------------------------------------




src/kded.cpp (line 223)
<https://git.reviewboard.kde.org/r/126769/#comment62424>

    That's new in Qt 5.5, we need this code to compile with Qt >= 5.3 (until 5.6 is out).
    
    Please revert, or wrap this in
    #if QT_VERSION >= QT_VERSION_CHECK(5, 5, 0)


- David Faure


On Jan. 16, 2016, 2:27 p.m., Andrey Cygankov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126769/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 2:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Fix all Clazy warnings in KDED.
> 
> 
> Diffs
> -----
> 
>   src/kded.cpp 0eb6380 
> 
> Diff: https://git.reviewboard.kde.org/r/126769/diff/
> 
> 
> Testing
> -------
> 
> Built without errors.
> No tests available.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160119/90d97299/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list