Review Request 126737: Fix most Clazy warnings in KItemViews.

Andrey Cygankov craftplace.ms at gmail.com
Thu Jan 14 22:40:32 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/
-----------------------------------------------------------

(Updated Янв. 14, 2016, 10:40 п.п.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.


Repository: kitemviews


Description
-------

Fix Clazy warnings, except:
/src/kwidgetitemdelegatepool.cpp:153:5: warning: Calling qDeleteAll with QHash::keys, call qDeleteAll on the container itself [-Wclazy-qdeleteall]
    qDeleteAll(d->widgetInIndex.keys());


Diffs (updated)
-----

  autotests/klistwidgetsearchlinetest.cpp b86d62c 
  src/kcategorizedview.cpp 185c24c 
  src/ktreewidgetsearchline.cpp b721c58 
  tests/kcategorizedviewtest.cpp 16dac9a 
  tests/ktreewidgetsearchlinetest.cpp adaf246 
  tests/kwidgetitemdelegatetest.cpp d4bba7a 

Diff: https://git.reviewboard.kde.org/r/126737/diff/


Testing
-------

Build without errors.
Tests passed.


Thanks,

Andrey Cygankov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160114/87fd0bb6/attachment.html>


More information about the Kde-frameworks-devel mailing list