Review Request 126746: Fix compilation with Qt5.6

David Edmundson david at davidedmundson.co.uk
Thu Jan 14 17:51:05 UTC 2016



> On Jan. 14, 2016, 5:48 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 36
> > <https://git.reviewboard.kde.org/r/126746/diff/1/?file=430690#file430690line36>
> >
> >     Can't this be -std=c++11 by now?

It possibly could, but I opted for copying the same line as kde-modules/KDECompilerSettings.cmake


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126746/#review91098
-----------------------------------------------------------


On Jan. 14, 2016, 5:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126746/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: polkit-qt-1
> 
> 
> Description
> -------
> 
> Qt5.6 has c++0x in code in the headers, so it needs explicitly adding as a compile flag when not using ECM.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bb91bdedc96b8211eb29a1180c2e451dc60fae18 
> 
> Diff: https://git.reviewboard.kde.org/r/126746/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160114/ab2b2763/attachment.html>


More information about the Kde-frameworks-devel mailing list