Review Request 126737: Fix most Clazy warnings in KItemViews.
Sergio Martins
smartins at kde.org
Thu Jan 14 13:04:29 UTC 2016
> On Jan. 14, 2016, 1:03 p.m., Sergio Martins wrote:
> > Ship It!
Can you push it in two different commits ? One for the QStringLiteral change and another for the isEmpty()
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/#review91076
-----------------------------------------------------------
On Jan. 14, 2016, 12:35 p.m., Andrey Cygankov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126737/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 12:35 p.m.)
>
>
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
>
>
> Repository: kitemviews
>
>
> Description
> -------
>
> Fix Clazy warnings, except:
> /src/kwidgetitemdelegatepool.cpp:153:5: warning: Calling qDeleteAll with QHash::keys, call qDeleteAll on the container itself [-Wclazy-qdeleteall]
> qDeleteAll(d->widgetInIndex.keys());
>
>
> Diffs
> -----
>
> autotests/klistwidgetsearchlinetest.cpp b86d62c
> src/kcategorizedview.cpp 185c24c
> src/ktreewidgetsearchline.cpp b721c58
> tests/kcategorizedviewtest.cpp 16dac9a
> tests/ktreewidgetsearchlinetest.cpp adaf246
> tests/kwidgetitemdelegatetest.cpp d4bba7a
>
> Diff: https://git.reviewboard.kde.org/r/126737/diff/
>
>
> Testing
> -------
>
> Build without errors.
> Tests passed.
>
>
> Thanks,
>
> Andrey Cygankov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160114/ac1ccfa3/attachment.html>
More information about the Kde-frameworks-devel
mailing list