Review Request 126738: Remove external dependencies from svgs
Dirk Hohndel
dirk at hohndel.org
Thu Jan 14 04:51:06 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126738/#review91047
-----------------------------------------------------------
this will need to be done for dozens more SVGs - I sent the four that I needed for my app for review, but if this change gets accepted I'll volunteer to rewrite all of the SVGs that contain external references. It just seemed silly to spend hours doing that and then have the project reject the change :-)
- Dirk Hohndel
On Jan. 14, 2016, 1:18 a.m., Dirk Hohndel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126738/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 1:18 a.m.)
>
>
> Review request for KDE Frameworks, andreas kainz and Uri Herrera.
>
>
> Repository: breeze-icons
>
>
> Description
> -------
>
> I don't know what I'm doing here. But when using the icons in a QML app I
> get a lot of warnings like this one:
>
> Could not resolve property : linearGradient4548
>
> Running the svgs through inkscape and using the "clean up document"
> function results in this commit (and the warnings are gone).
>
> This may not be the right thing to do but it would be nice to get rid of
> all these warnings when using the icons.
>
> Signed-off-by: Dirk Hohndel <dirk at hohndel.org>
>
>
> Diffs
> -----
>
> icons/actions/24/dialog-cancel.svg a2b022a9dc7b7cf97e4c3391b87e7800355d2dcb
> icons/actions/24/distribute-horizontal-x.svg 262fcaca937cb72d8393fd5dff9c59651367fe36
> icons/actions/24/document-edit.svg afb37ca9624b37d6ac5aa9c94f1b2cef620faff6
> icons/actions/24/document-save.svg cee0a3521deb7eb1fcb79266afaa8951f4984b20
>
> Diff: https://git.reviewboard.kde.org/r/126738/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dirk Hohndel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160114/4980d2b3/attachment.html>
More information about the Kde-frameworks-devel
mailing list