Review Request 126734: Fix Clazy warnings in KNotifications.
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Jan 13 23:55:17 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126734/#review91038
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 14, 2016, 12:51 a.m., Andrey Cygankov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126734/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 12:51 a.m.)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Fix Clazy warnings in KNotifications.
> Fixed all but the these warnings:
> /src/kstatusnotifieritemdbus_p.cpp:189:12: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritemdbus_p.cpp:204:12: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritem.cpp:109:47: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritem.cpp:532:51: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritem.cpp:974:14: [-Wclazy-foreach]
> Maybe it false-positive warnings?
>
>
> Diffs
> -----
>
> src/knotificationrestrictions.cpp c979a78
> src/kstatusnotifieritem.cpp f9bf460
> src/notifybypopup.cpp e3090ba
> src/notifybypopupgrowl.cpp 504ad90
>
> Diff: https://git.reviewboard.kde.org/r/126734/diff/
>
>
> Testing
> -------
>
> Built without errors.
> No tests available.
>
>
> Thanks,
>
> Andrey Cygankov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160113/1bbff39d/attachment.html>
More information about the Kde-frameworks-devel
mailing list