Review Request 126734: Fix Clazy warnings in KNotifications.

[Aleix Pol Gonzalez]

> On Jan. 14, 2016, 12:30 a.m., Aleix Pol Gonzalez wrote:
> > Only the foreach I don't understand, as for the rest, note that `NewStatus` first argument is `QString`.
> > 
> > Use QString::fromLatin1().
> 
> Andrey Cygankov wrote:
>     What to put in kstatusnotifieritemdbus_.cpp ?

`return QLatin1String(m_statusNotifierItem->metaObject()->enumerator(m_statusNotifierItem->metaObject()->indexOfEnumerator("ItemStatus")).valueToKey(m_statusNotifierItem->status()));`

And similarly with the other one.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126734/#review91034
-----------------------------------------------------------


On Jan. 14, 2016, 12:30 a.m., Andrey Cygankov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126734/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 12:30 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Fix Clazy warnings in KNotifications.
> Fixed all but the these warnings:
> /src/kstatusnotifieritemdbus_p.cpp:189:12: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritemdbus_p.cpp:204:12: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritem.cpp:109:47: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritem.cpp:532:51: [-Wclazy-qstring-uneeded-heap-allocations]
> /src/kstatusnotifieritem.cpp:974:14: [-Wclazy-foreach]
> Maybe it false-positive warnings?
> 
> 
> Diffs
> -----
> 
>   src/knotificationrestrictions.cpp c979a78 
>   src/notifybypopup.cpp e3090ba 
>   src/notifybypopupgrowl.cpp 504ad90 
> 
> Diff: https://git.reviewboard.kde.org/r/126734/diff/
> 
> 
> Testing
> -------
> 
> Built without errors.
> No tests available.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160113/ddb77090/attachment-0001.html>