Review Request 126632: add a "Complementary" color scheme to kcolorscheme
Marco Martin
notmart at gmail.com
Wed Jan 13 11:06:41 UTC 2016
> On Jan. 11, 2016, 12:14 p.m., David Edmundson wrote:
> > >Gwenview switches to a dark palette when in fullscreen mode for instance
> >
> > and how does this help solve that? There's no method to get a palette from a ColorSet
>
> Marco Martin wrote:
> that may be useful to add then?
since i plan to make the default plasma theme folow the system color, i kinda need this soon-ish.
what extra things i need to do for this patch to be good to go?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126632/#review90886
-----------------------------------------------------------
On Jan. 5, 2016, 11:16 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126632/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:16 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kconfigwidgets
>
>
> Description
> -------
>
> Since some releases, plasma-frameworks locally expands kcolorscheme to have a new "Complementary" section: this is done for things like the lockscreen and the logout ui, where the colors are flipped from the current theme.
> A local extension there is kinda unfortunate as makes the color configs files not completely compatible, and I think there is an use case for this in normal applications as well (Gwenview switches to a dark palette when in fullscreen mode for instance)
> Since I want to make the default plasma theme follow the system color scheme, I would need for it to support this "complementary" area as well.
>
>
> Diffs
> -----
>
> src/kcolorscheme.h 22bc21b
> src/kcolorscheme.cpp 427ffa4
>
> Diff: https://git.reviewboard.kde.org/r/126632/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160113/8ceff99e/attachment.html>
More information about the Kde-frameworks-devel
mailing list