Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync
David Edmundson
david at davidedmundson.co.uk
Tue Jan 12 14:43:46 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126723/#review90970
-----------------------------------------------------------
core/polkitqt1-subject.cpp (line 184)
<https://git.reviewboard.kde.org/r/126723/#comment62143>
Identity
whcih this inherits from
has a QExplicitlySharedDataPointer for it's private data
I think you can just return the object rather than a pointer
- David Edmundson
On Jan. 12, 2016, 9:09 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126723/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 9:09 a.m.)
>
>
> Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and Matthias Klumpp.
>
>
> Repository: polkit-qt-1
>
>
> Description
> -------
>
> This adds a new method to SystemBusNameSubject to get to the
> UnixUserIdentity for the subject.
>
>
> Diffs
> -----
>
> core/polkitqt1-subject.h 4c7a22bae51a501f9aed2eadac0579baea174d0d
> core/polkitqt1-subject.cpp f0d69c647f00728525ee78e946a938f270ddb300
>
> Diff: https://git.reviewboard.kde.org/r/126723/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160112/fa34b0e5/attachment.html>
More information about the Kde-frameworks-devel
mailing list