Review Request 126717: Fix DBus service name of polkit agent

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126717/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 7:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Edmundson.


Changes
-------

Submitted with commit 815ddf5628324ea550c01c701fe3b124b8a19762 by Martin Gräßlin to branch master.


Repository: kauth


Description
-------

It's nowadays org.kde.polkit-kde-authentication-agent-1.

Also perform preAuthAction for Backends with AuthorizeFromHelperCapability

The Polkit backend implements preAuthAction and performs the passing of
winId there. The current implementation never called into it as the
preAuthAction is not performed for backends with the
AuthorizeFromHelperCapability.

If both AuthorizeFromHelperCapability and PreAuthActionCapability are set
we call it again.


Diffs
-----

  src/backends/polkit-1/Polkit1Backend.cpp cf0b7073688f2caa02fa9cfe1d483a0f1512e423 
  src/kauthexecutejob.cpp d92b7e9c47478bdf5a6f1c6361d5c48d61c836e6 

Diff: https://git.reviewboard.kde.org/r/126717/diff/


Testing
-------

xprop on the auth dialog and xwininfo on the window which caused the action:

    _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE
    _KDE_NET_WM_FRAME_STRUT(CARDINAL) = 4, 4, 29, 4
    _NET_FRAME_EXTENTS(CARDINAL) = 4, 4, 29, 4
    _NET_WM_DESKTOP(CARDINAL) = 0
    _KDE_NET_WM_ACTIVITIES(STRING) = "00000000-0000-0000-0000-000000000000"
    WM_STATE(WM_STATE):
                window state: Normal
                icon window: 0x0
    _NET_WM_STATE(ATOM) = 
    _NET_WM_USER_TIME(CARDINAL) = 29673761
    WM_TRANSIENT_FOR(WINDOW): window id # 0x4e00009
    _WM_ICON_NAME(UTF8_STRING) = 
    XdndAware(ATOM) = BITMAP
    _KDE_NET_WM_USER_CREATION_TIME(CARDINAL) = 29673731
    WM_NAME(STRING) = "Authentication Required"
    _NET_WM_NAME(UTF8_STRING) = "Authentication Required"
    _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x26, 0x1e, 0x0, 0x0
    _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DIALOG, _NET_WM_WINDOW_TYPE_NORMAL
    _XEMBED_INFO(_XEMBED_INFO) = 0x0, 0x1
    WM_CLIENT_LEADER(WINDOW): window id # 0x2400005
    WM_HINTS(WM_HINTS):
                Client accepts input or input focus: True
                Initial state is Normal State.
    _NET_WM_PID(CARDINAL) = 2034
    WM_CLASS(STRING) = "polkit-kde-authentication-agent-1", "polkit-kde-authentication-agent-1"
    WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, WM_TAKE_FOCUS, _NET_WM_PING, _NET_WM_CONTEXT_HELP
    WM_NORMAL_HINTS(WM_SIZE_HINTS):
                user specified location: 390, 300
                user specified size: 511 by 344
                program specified minimum size: 404 by 202
                window gravity: Static
    martin at martin-desktop: ~ $ xwininfo 

    xwininfo: Please select the window about which you
          would like information by clicking the
          mouse in that window.

    xwininfo: Window id: 0x4e00009 "Screen Locking — KDE Control Module"

    Absolute upper-left X:  704
    Absolute upper-left Y:  318
    Relative upper-left X:  0
    Relative upper-left Y:  0
    Width: 555
    Height: 364
    Depth: 24
    Visual: 0xbd
    Visual Class: TrueColor
    Border width: 0
    Class: InputOutput
    Colormap: 0x4e00008 (not installed)
    Bit Gravity State: ForgetGravity
    Window Gravity State: NorthWestGravity
    Backing Store State: NotUseful
    Save Under State: no
    Map State: IsViewable
    Override Redirect State: no
    Corners:  +704+318  -1941+318  -1941-398  +704-398
    -geometry 555x364+704+318


Observe: WM_TRANSIENT_FOR is set correctly.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160112/2f346fee/attachment.html>