Review Request 126684: fix loading of RLE compressed PSD files

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126684/
-----------------------------------------------------------

(Updated Jan. 10, 2016, 12:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
-------

Submitted with commit 5d7ef7c38e9f6aa473fec5ee7f1daabcb405ffd7 by Wolfgang Bauer to branch master.


Bugs: 354413
    https://bugs.kde.org/show_bug.cgi?id=354413


Repository: kimageformats


Description
-------

decodeRLEData() expects a quint16 as length, but the PSD loader calls it with a quint32.
We do need quint32 for PSD (it's the pixel count there, i.e. width x height), otherwise it would overflow for files bigger than 256x256 pixels.


Diffs
-----

  src/imageformats/rle_p.h 71d6b2c 

Diff: https://git.reviewboard.kde.org/r/126684/diff/


Testing
-------

RLE compressed PSD files now load fine in applications like (the KF5 based) gwenview, kolourpaint and okular, thumbnails are shown correctly in dolphin too.

PIC files still work as well.

The tests still pass.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160110/6e1a4e95/attachment.html>