Review Request 126695: Fix clang warning about implicit copy ctor and explicit operator=.

Kevin Funk kfunk at kde.org
Sun Jan 10 12:03:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126695/#review90838
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Jan. 10, 2016, 11:03 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126695/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2016, 11:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> QList calls both, so both are needed, but indeed operator= means the
> members can't be const. Let's just remove the const for the members
> rather than use const_cast.
> 
> Change-Id: I9e749a448dc69439ba34ceed31fd7f0032f68c3b
> 
> 
> Diffs
> -----
> 
>   src/core/ksslcertificatemanager_p.h 0b9a85d6f05b93dbe8e80962401dff5ca73617f8 
> 
> Diff: https://git.reviewboard.kde.org/r/126695/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160110/210e1170/attachment.html>


More information about the Kde-frameworks-devel mailing list