Review Request 126681: Duplicate the file descriptor while opening

[David Faure]

> On Jan. 9, 2016, 1:28 p.m., Kai Uwe Broulik wrote:
> > I think we should do a re-spin of KF 5.18?
> 
> Luigi Toscano wrote:
>     I think it was already done: https://mail.kde.org/pipermail/release-team/2016-January/009263.html
> 
> Kai Uwe Broulik wrote:
>     ok, I was just wondering because it wasn't mentioned in the changelog :)
> 
> David Faure wrote:
>     A changelog is only a summary of the changes that impact the users of the framework, not the full git log.
>     
>     When a release contains a change, and then a "oops" fix for the change, I remove the oops commit, it's irrelevant to the users of the release, who have never hit the temporary problem introduced by the first version of the change.
>     
>     To know if a commit is in a release, better trust the git tag.

"I remove the oops commit" ... from the changelog, of course.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126681/#review90814
-----------------------------------------------------------


On Jan. 8, 2016, 9:41 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126681/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 9:41 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> Closing the fd results in kwallet being in a blocked state
> with all requests to it being timed out.
> 
> This fixes the issue.
> 
> Thanks to Christoph Cullmann spotting the issue.
> 
> 
> Diffs
> -----
> 
>   src/runtime/kwalletd/main.cpp a48de08 
> 
> Diff: https://git.reviewboard.kde.org/r/126681/diff/
> 
> 
> Testing
> -------
> 
> KWallet no longer times out after login.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160110/ebd2c56e/attachment-0001.html>