Review Request 126670: Fix some Clazy warnings in KPeople framework

Andrey Cygankov craftplace.ms at gmail.com
Fri Jan 8 01:15:11 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126670/
-----------------------------------------------------------

(Updated Jan. 8, 2016, 2:15 a.m.)


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Summary (updated)
-----------------

Fix some Clazy warnings in KPeople framework


Repository: kpeople


Description
-------

Fix some Clazy warnings:
- qstring-uneeded-heap-allocations
- isempty-vs-count
- detaching-temporary
- variant-sanitizer


Diffs
-----

  autotests/persondatatests.cpp 43a7c7b 
  autotests/personsmodeltest.cpp 1cbc3dc 
  examples/contactlistwidgets.cpp 56bb01c 
  examples/personwidget.cpp b4d73c8 
  src/personmanager.cpp 5c3d3e1 
  src/personpluginmanager.cpp f5396d9 
  src/widgets/actions.cpp ffaf16f 
  src/widgets/mergedelegate.cpp 01c988d 
  src/widgets/persondetailsview.cpp 7e4e24f 

Diff: https://git.reviewboard.kde.org/r/126670/diff/


Testing
-------

Compiling without errors.


Thanks,

Andrey Cygankov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160108/4d5b4c03/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list