Review Request 126662: [GCI] Fix clazy's issues in core lib.
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Jan 7 15:51:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126662/#review90762
-----------------------------------------------------------
src/kpackage/packageloader.cpp (line 219)
<https://git.reviewboard.kde.org/r/126662/#comment62051>
I would just change for Q_FOREACH.
src/kpackage/packageloader.cpp (line 274)
<https://git.reviewboard.kde.org/r/126662/#comment62052>
I would just change for Q_FOREACH.
src/kpackagetool/kpackagetool.cpp (line 351)
<https://git.reviewboard.kde.org/r/126662/#comment62054>
Why's this change?
src/kpackagetool/kpackagetool.cpp (line 516)
<https://git.reviewboard.kde.org/r/126662/#comment62053>
I would just change for Q_FOREACH.
- Aleix Pol Gonzalez
On Jan. 7, 2016, 4:42 p.m., Mihail Ivchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126662/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 4:42 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kpackage
>
>
> Description
> -------
>
> GCI task: https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
>
>
> Diffs
> -----
>
> src/kpackagetool/kpackagetool.cpp 61a0043
> src/kpackage/private/packages_p.h 27b8ed9
> src/kpackage/packageloader.cpp 9f7dd48
>
> Diff: https://git.reviewboard.kde.org/r/126662/diff/
>
>
> Testing
> -------
>
> Tests passed
>
>
> Thanks,
>
> Mihail Ivchenko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160107/9b8f6715/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list