Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jan 7 15:49:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126661/#review90761
-----------------------------------------------------------



src/kpackage/package.cpp (line 227)
<https://git.reviewboard.kde.org/r/126661/#comment62050>

    this should be `endsWith(QLatin1Char('/'))`


- Aleix Pol Gonzalez


On Jan. 7, 2016, 4:41 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126661/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 4:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> QLatin1String -> QStringLiteral where it makes sense.
> Raw string literals -> QStringLiteral and QLatin1String (where possible).
> GCI task: https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -----
> 
>   src/kpackage/private/packagejobthread.cpp b7f5d2d 
>   src/kpackage/package.cpp d210015 
>   src/kpackage/packageloader.cpp 9f7dd48 
>   src/kpackage/private/packages.cpp 3de80a0 
>   src/kpackagetool/kpackagetool.cpp 61a0043 
>   src/kpackagetool/main.cpp 453f3e8 
> 
> Diff: https://git.reviewboard.kde.org/r/126661/diff/
> 
> 
> Testing
> -------
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160107/816bf9de/attachment.html>


More information about the Kde-frameworks-devel mailing list