Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 12:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, kdelibs and David Faure.


Changes
-------

Submitted with commit 68af1d7e89b7fed136d4cc62b76c1c6ded2d94eb by Wolfgang Bauer to branch master.


Bugs: 354597
    https://bugs.kde.org/show_bug.cgi?id=354597


Repository: kio


Description
-------

- QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so subtracting 1900 is wrong.
- Use QDate::currentDate() instead of QDateTime::currentDateTime(), we only need the current date anyway
- Initialize day, month, and year to the current date instead of 0. In the case when no year is mentioned in the server's reply (the year is implicit), it wasn't set to the current year at all, so the result was either 0 or -1.


Diffs
-----

  src/ioslaves/ftp/ftp.cpp 2179179 

Diff: https://git.reviewboard.kde.org/r/126659/diff/


Testing
-------

Connected to an FTP server with dolphin (15.12.0). The modification times/dates are now shown correctly.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160107/4df92f71/attachment.html>