Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 1:21 nachm.)


Review request for KDE Frameworks, kdelibs and David Faure.


Changes
-------

- Use QDate::currentDate() instead of QDateTime::currentDateTime(), we only need the date anyway
- initialize day, month, and year to the current date instead of 0


Bugs: 354597
    https://bugs.kde.org/show_bug.cgi?id=354597


Repository: kio


Description
-------

- QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so subtracting 1900 is wrong.
- in the case when no year is mentioned in the server's reply (the year is implicit), it wasn't set to the current year, so the result was either 0 or -1.


Diffs (updated)
-----

  src/ioslaves/ftp/ftp.cpp 2179179 

Diff: https://git.reviewboard.kde.org/r/126659/diff/


Testing
-------

Connected to an FTP server with dolphin (15.12.0). The modification times/dates are now shown correctly.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160107/0486a7d6/attachment.html>