Review Request 126403: Get rid of QApplication dependency

Thomas Lübking thomas.luebking at gmail.com
Wed Jan 6 17:33:32 UTC 2016



> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote:
> > anyone tested this on an "affected system"?
> 
> Albert Astals Cid wrote:
>     I have not, I thought you had made it clear in the past you thought it was a bad idea since it was all supposed to be widget based anyway.
> 
> Thomas Lübking wrote:
>     We're trying to resolve this ;-)
>     
>     KWindowSystem could otherwise never be used by QGuiApplication's
>     As bonus, we can probably unlink Qt6Widgets in "it's certainly not called KF6 - that would be far too simple" :-P
>     (I'm not sure whether we can/should that right now - while you should explicitly link stuff you need, we don't live in a should-land)
>     
>     => If you can, give it a try (compiz isn't provided by my distro)
> 
> Albert Astals Cid wrote:
>     I can be your tester if you tell me what to test.
> 
> Thomas Lübking wrote:
>     Make kscreenlocker_greet crash when using compiz as WM, see bug #354811
> 
> Albert Astals Cid wrote:
>     Running /usr/lib/x86_64-linux-gnu/libexec/kscreenlocker_greet on Ubuntu Xenial under Unity7 crashes before applying this patch to kwindowsystem and seems to work fine after applying the patch.

That's the desired result, many thanks for your effort.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126403/#review90522
-----------------------------------------------------------


On Jan. 2, 2016, 9:57 a.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126403/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2016, 9:57 a.m.)
> 
> 
> Review request for KDE Frameworks, kwin and Albert Astals Cid.
> 
> 
> Bugs: 354811
>     https://bugs.kde.org/show_bug.cgi?id=354811
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> summarized, alternative to https://git.reviewboard.kde.org/r/126397/
> 
> NOTICE: this compiles but is otherwise *completely* untested!
> 
> 
> Diffs
> -----
> 
>   src/platforms/xcb/kwindowsystem.cpp 9d28704 
> 
> Diff: https://git.reviewboard.kde.org/r/126403/diff/
> 
> 
> Testing
> -------
> 
> no, not the least. esp. not on the bug.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160106/955b4766/attachment.html>


More information about the Kde-frameworks-devel mailing list