Review Request 126648: Allow to disable KArchive for internal usage

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126648/#review90682
-----------------------------------------------------------

Ship it!



src/xslt_kde.cpp (line 17)
<https://git.reviewboard.kde.org/r/126648/#comment61977>

    I would suggest to add a qWarning() under this line, to warn at runtime in case this is ever called in a non-karchive build.


- David Faure


On Jan. 6, 2016, 12:58 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126648/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 12:58 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Alex Merry, and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Most of the code was already prepared to compile without the KArchive dependency (including the MEINPROC_NO_KARCHIVE flag).
> This mode should be only enabled on KDE infrastructure, as the compressed cache (the only added feature coming from KArchive) is not used by the generator of the documentation website.
> A warning is printed when the mode is enabled.
> The saveToCache function is preserved, even if without code, to minimize the changes required.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2ec3027 
>   src/CMakeLists.txt 136fbfb 
>   src/xslt_kde.cpp 7069a28 
> 
> Diff: https://git.reviewboard.kde.org/r/126648/diff/
> 
> 
> Testing
> -------
> 
> Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160106/c16b05a1/attachment.html>