Review Request 126426: Add a warning color to kwalletd's password dialogs

Elvis Angelaccio elvis.angelaccio at kdemail.net
Mon Jan 4 15:05:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126426/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 3:05 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability and Valentin Rusu.


Changes
-------

Submitted with commit 8e8f16a6e11adfef0bbd9f006b46c62e13cdad4f by Elvis Angelaccio to branch master.


Repository: kwallet


Description
-------

Set a "background warning color" when password and its verification do not match, in the KNewPasswordDialog run by kwalletd.
This adds a new dependency (needed to avoid hardcoding colors), but I think is a nice feature to have.
See RR 125619 for a screenshot: https://git.reviewboard.kde.org/r/125619/file/2515/


Diffs
-----

  src/runtime/kwalletd/CMakeLists.txt ba9e7ba508c74fed1d8101496583061245640aa7 
  src/runtime/kwalletd/kwalletd.cpp 6da97031e13240a9630cfa7e0dc3cf42575819c4 

Diff: https://git.reviewboard.kde.org/r/126426/diff/


Testing
-------

Compiles fine.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160104/38738b05/attachment.html>


More information about the Kde-frameworks-devel mailing list