Review Request 126505: Do not show a warning color before the user even started typing

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126505/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 2:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability, Christoph Feck, and David Faure.


Changes
-------

Submitted with commit 2eab08790a1b9be46f32331d8710395f51902e8b by Elvis Angelaccio to branch master.


Repository: kwidgetsaddons


Description
-------

As discussed in RR 125619 and 126426, the password verification field (in a KNewPasswordWidget) should not be marked as "wrong" before the user even started typing the verification password.

The revised approach is the following:

* The user starts typing something as password, e.g. 1234
* The user types something else as verification password
* As soon as the verification is not anymore a prefix of the password (e.g. verification = 122), the warning color is shown.
* As soon as the verification is a prefix again (e.g. the user deletes the second 2, i.e. verification = 12) the warning color is not shown anymore.


Diffs
-----

  autotests/knewpasswordwidgettest.h 43845128adec01aced4353c9f7986b7977829a2a 
  autotests/knewpasswordwidgettest.cpp 297b88d5f18b9cd37f0d26d94e56f38870756f20 
  src/knewpasswordwidget.cpp a1b59454a2c2d7c09ac32acec52d3fffa73f77fc 

Diff: https://git.reviewboard.kde.org/r/126505/diff/


Testing
-------

Autotests assert what described above. Gif pictures would explain the patch better than 1000 words, but I suck at creating them :(


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160104/cac28494/attachment.html>