Review Request 126494: Add cross compile support for desktoptojson.

[Aleix Pol Gonzalez]

> On Jan. 4, 2016, 3:09 p.m., Aleix Pol Gonzalez wrote:
> > KF5CoreAddonsConfig.cmake.in, line 12
> > <https://git.reviewboard.kde.org/r/126494/diff/1/?file=425586#file425586line12>
> >
> >     What's that property supposed to do? `IMPORTED_LOCATION_NONE`
> 
> Ralf Habacker wrote:
>     If I remember correctly I took it from a different location in the framework code. Better to use IMPORTED_LOCATION ?
> 
> Aleix Pol Gonzalez wrote:
>     Better not use anything. This target should be properly exported already. My impression is that it's not working for you because you have mixed cmake build types.
> 
> Ralf Habacker wrote:
>     Not sure I understand you correctly: 
>     In cross compile environments a host provided desktoptojson executable is required to build kcoreaddons (tested with mingw32). With this patch I can specify -DDESKTOPTOJSON_EXECUTABLE=<host-provided-desktoptojson-executable> on the cmake command line (see https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-kf5-filesystem/macros.mingw32-kf5?expand=1 line 92ff) to solve this. Also it provides the host provided executable for packages requiring desktoptojson.

But that's not very practical, because you'll have to point to each and every target that it's used. You can consider adopting the `KF5_HOST_TOOLING` variable, which is meant for exactly this.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126494/#review90552
-----------------------------------------------------------


On Jan. 4, 2016, 3:11 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126494/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 3:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add cross compile support for desktoptojson.
> 
> 
> Diffs
> -----
> 
>   KF5CoreAddonsConfig.cmake.in dce3a4e65599b286d8fedbaa20235f5025f509e8 
> 
> Diff: https://git.reviewboard.kde.org/r/126494/diff/
> 
> 
> Testing
> -------
> 
> Cross compiled package has been build at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF516/mingw32-kcoreaddons
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160104/7ab9e326/attachment.html>