Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

[Martin Gräßlin]

> On Jan. 2, 2016, 10:59 a.m., David Edmundson wrote:
> > src/properties.h, line 215
> > <https://git.reviewboard.kde.org/r/126595/diff/2/?file=428207#file428207line215>
> >
> >     adding an enum value in the middle breaks API
> 
> Kai Uwe Broulik wrote:
>     where can I place it? the last entry of course must stay last.

I'd say you can add it before PropertyCount. That will change the value of PropertyCount, but that's kind of expected. It will break API, but it shouldn't affect in real world situations.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126595/#review90435
-----------------------------------------------------------


On Jan. 2, 2016, 2:32 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126595/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2016, 2:32 a.m.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> This attribute is set, for example by Chrome and newer versions of wget, and indicates the original URL this file was downloaded from.
> 
> https://wiki.freedesktop.org/www/CommonExtendedAttributes/
> 
> 
> Diffs
> -----
> 
>   src/properties.h 64ba0be 
>   src/propertyinfo.cpp 0b298b6 
>   src/usermetadata.h ab58e16 
>   src/usermetadata.cpp 51c87f8 
> 
> Diff: https://git.reviewboard.kde.org/r/126595/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160104/2c6167cc/attachment.html>