Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Jan 3 17:19:48 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126614/#review90504
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 3, 2016, 1:45 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126614/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 1:45 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: ki18n
>
>
> Description
> -------
>
> Strings that are separated into multiple parts don't work on Windows
> together with QStringLiteral as the first string is interpreted as a
> wide (16bit) string, and the second one as a narrow (8bit) string. (Copy pasted from Patrick Spendrin's RR)
>
> Joining the strings here.
>
>
> Diffs
> -----
>
> src/kuitmarkup.cpp 9831b34
>
> Diff: https://git.reviewboard.kde.org/r/126614/diff/
>
>
> Testing
> -------
>
> Compiles again on windows
>
>
> Thanks,
>
> Kåre Särs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160103/c6f0c0b1/attachment.html>
More information about the Kde-frameworks-devel
mailing list