Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

[Alex Richardson]

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote:
> > According to the documentation AppLocalDataLocation is the following: "C:/Users/<USER>/AppData/Local/<APPNAME>", "C:/ProgramData/<APPNAME>", "<APPDIR>", "<APPDIR>/data"
> > 
> > In which directory are the desktop files? Unfortunately I can't check as my Windows machine broke a while back and I haven't compiled KF5 on Windows since.
> > 
> > Patch looks good to me otherwise as it will still check the same directories change behaviour on Linux. Only minor issue is that the error message is a little bit confusing now.
> 
> Christoph Cullmann wrote:
>     hi, same problem occurs on mac, too, i think a better fallback would be something install prefix relative, that would work on win + mac.

Would checking `${KDE_INSTALL_FULL_KSERVICETYPES5DIR} + path` first and then fall back to GenericDataLocation work on Windows and Mac? Or do we still need the AppDataLocation for runtime detection of the paths?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126618/#review90496
-----------------------------------------------------------


On Jan. 3, 2016, 1:22 p.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126618/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2016, 1:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Without this patch kcoreaddons_desktop_to_json() will not find the destop file.
> 
> On windows GenericDataLocation returns "C:/Users/<USER>/AppData/Local" or "C:/ProgramData". That is not a path that contains any destip files ;)
> 
> This patch adds AppLocalDataLocation to the seach if the previous search does not return a match. 
> 
> Another option would be to hardcode the absolute path to all places that uses kcoreaddons_desktop_to_json(), but that does not feel too nice...
> 
> What other options do we have?
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/desktopfileparser.cpp 1122af8 
> 
> Diff: https://git.reviewboard.kde.org/r/126618/diff/
> 
> 
> Testing
> -------
> 
> KTextEditor compiles again on windows
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160103/d7ab4776/attachment.html>