Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows
Kåre Särs
kare.sars at iki.fi
Sun Jan 3 12:45:19 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126614/
-----------------------------------------------------------
(Updated Jan. 3, 2016, 12:45 p.m.)
Review request for KDE Frameworks.
Changes
-------
change summary as there are multiple reviews with the same summary
Summary (updated)
-----------------
(Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows
Repository: ki18n
Description
-------
Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string. (Copy pasted from Patrick Spendrin's RR)
Joining the strings here.
Diffs
-----
src/kuitmarkup.cpp 9831b34
Diff: https://git.reviewboard.kde.org/r/126614/diff/
Testing
-------
Compiles again on windows
Thanks,
Kåre Särs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160103/96069c70/attachment.html>
More information about the Kde-frameworks-devel
mailing list