Review Request 126615: Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

Kåre Särs kare.sars at iki.fi
Sun Jan 3 12:40:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126615/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: knewstuff


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string. (Copy pasted from Patrick Spendrin's RR)

Replacing QStringLitearl() with QLatin1String()


Diffs
-----

  src/CMakeLists.txt cc60644 
  src/ui/itemsviewdelegate.cpp 8a891ba 

Diff: https://git.reviewboard.kde.org/r/126615/diff/


Testing
-------

Compiles again on windows


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160103/2ca6bf3c/attachment.html>


More information about the Kde-frameworks-devel mailing list