Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

David Edmundson david at davidedmundson.co.uk
Sat Jan 2 22:32:04 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126474/
-----------------------------------------------------------

(Updated Jan. 2, 2016, 10:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 6763f7a6cab41fc4c94be783305ac2c8e85ccaa1 by David Edmundson to branch master.


Repository: kio


Description
-------

A static QRegExp was used but it is not thread safe. QRegularExpression
seems to be.

BUG: 352356


Diffs
-----

  src/urifilters/shorturi/kshorturifilter.cpp 6002ec6925c0acdd20a053f98baca46863f69fa6 

Diff: https://git.reviewboard.kde.org/r/126474/diff/


Testing
-------

I ran the autotests which includes urifilter and I've run krunner which uses it extensively.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160102/71406e36/attachment.html>


More information about the Kde-frameworks-devel mailing list